feat(FR-1426): conditionally show terminal guide based on copy feature support #4414
Conversation
github-actions
bot
added
area:lib
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR conditionally displays the terminal guide dialog based on whether the Backend.AI manager supports the new copy-on-terminal feature (version 25.13.2+). When the feature is supported, the guide dialog is suppressed since users can copy text directly via mouse selection in tmux, eliminating the need for instructional popup.
Key changes:
- Added
copy-on-terminalfeature flag for manager version 25.13.2+ - Modified terminal guide dialog to display only when copy-on-terminal is not supported
- Corrected placement of
reservoirfeature flag to version 25.12.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/backend.ai-client-esm.ts | Added copy-on-terminal feature flag and repositioned reservoir flag to correct version block |
| src/components/backend-ai-app-launcher.ts | Added conditional check to show terminal guide only when copy-on-terminal is unsupported |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| !globalThis.backendaiclient.supports('copy-on-terminal') && | ||
| this.terminalGuideDialog.show(); |
There was a problem hiding this comment.
[nitpick] Using the && short-circuit operator for a conditional action reduces readability. Consider using an explicit if statement: if (!globalThis.backendaiclient.supports('copy-on-terminal')) { this.terminalGuideDialog.show(); }
| !globalThis.backendaiclient.supports('copy-on-terminal') && | |
| this.terminalGuideDialog.show(); | |
| if (!globalThis.backendaiclient.supports('copy-on-terminal')) { | |
| this.terminalGuideDialog.show(); | |
| } |
2 participants
Resolves #4220 (FR-1426)
Changes
This PR implements conditional display of the terminal guide dialog based on the new copy-on-terminal feature support.
Key Changes
Added copy-on-terminal feature flag
Conditional terminal guide display
copy-on-terminalfeature is NOT supportedCode organization
reservoirfeature flag to correct version section (25.12.0)Files Changed
src/components/backend-ai-app-launcher.ts- Conditional terminal guide dialog displaysrc/lib/backend.ai-client-esm.ts- Added feature flags for version compatibilityBackground
With the new copy-on-terminal feature (manager v25.13.2+), users can copy text by simply selecting it with the mouse when tmux mouse setting is enabled. This makes the terminal guide popup unnecessary for newer versions.
Checklist: